git - Restarting a pull request, with some files that haven't changed since original -
over month ago set pull request on github repository, asking comments. got them, , have been taking them account.
that pr still there , i've changed plenty files in pr branch i'm little leery of modifying existing pr-- comments dealing stale code now, etc. ideally i'd close , open new one.
my question how best it. in local repo files part of pr, , untouched since, no longer marked modified. if close pr how force them new pr more recent changes?
you can update branch pull request based off, in pr page you'll see both original commits, comments made on them, , commits made address comments. have whole history of work, , can audit - or that.
you rebase , push -f branch old commits fixed - instead of adding new ones -, , you'll prettier history. lose old commits appearing in pr, it's harder see comments talk about, nicer history log.
in anyway, creating new pull request lose relationship between new changes , comments received, seems shame - nil improve seeing issues addressing while made changes!
git github
No comments:
Post a Comment